Add more efficient solution to Longest Consecutive Sequence - Python #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethancdaniel
changed the title
|
Nvm, the entire speedup comes from iterating over the set rather than the array, so this is a duplicate of #2520. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in the video solution, values were being repeatedly iterated over. Making my small change of iterating over the items remaining in the set rather than the entire array improves speed from 1500 ms to 350 ms.
While they have the end up having the same Big O notation, I feel like it's a big enough speed improvement to include in the solutions. Since it differs from the video, I followed the contributing guidelines and added it as another method. I noticed the same problem in other languages and would be happy to update those in future PRs if this one goes through.
My solution
Current solution
